Skip to content

[i18n-ar] Translated file : docs/source/ar/multilingual.md into Arabic#33048

Merged
stevhliu merged 31 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_multilingual.md
Oct 31, 2024
Merged

[i18n-ar] Translated file : docs/source/ar/multilingual.md into Arabic#33048
stevhliu merged 31 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_multilingual.md

Conversation

@AhmedAlmaghz

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the docs/source/ar/multilingual.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

@abodacs abodacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

السﻻم عليكم
@AhmedAlmaghz
تمت المراجعة جزاء الله خيرا

Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
Comment thread docs/source/ar/multilingual.md Outdated
AhmedAlmaghz and others added 16 commits October 26, 2024 22:06
@AhmedAlmaghz
AhmedAlmaghz marked this pull request as ready for review October 26, 2024 20:52
@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Thank you @abodacs

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the translation! Remember to add it to the toctree 🙂

@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Done @stevhliu
Please, merging

@AhmedAlmaghz

AhmedAlmaghz commented Oct 30, 2024

Copy link
Copy Markdown
Contributor Author

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tflite and gguf docs are also missing from the toctree ;)

@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Done
@stevhliu

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments

Comment thread docs/source/ar/custom_models.md
Comment thread docs/source/ar/chat_templating.md Outdated
Comment thread docs/source/ar/create_a_model.md Outdated
Comment thread docs/source/ar/create_a_model.md Outdated
Comment thread docs/source/ar/gguf.md Outdated
Comment thread docs/source/ar/gguf.md Outdated
@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Thank you @stevhliu
Done

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@stevhliu
stevhliu merged commit b53e44e into huggingface:main Oct 31, 2024
@AhmedAlmaghz

Copy link
Copy Markdown
Contributor Author

Thank you:
@abodacs
@stevhliu

@AhmedAlmaghz
AhmedAlmaghz deleted the Add_docs_source_ar_multilingual.md branch November 5, 2024 16:45
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…bic (huggingface#33048)

* Add docs/source/ar/multilingual.md to Add_docs_source_ar_multilingual.md

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/multilingual.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update _toctree.yml

* Update _toctree.yml

* Add Translated files to branch for merg

* Update _toctree.yml

* Update _toctree.yml

* Update custom_models.md

* Update chat_templating.md

* Update docs/source/ar/create_a_model.md

Co-authored-by: Steven Liu <[email protected]>

* Update create_a_model.md

* Update gguf.md

* Update gguf.md

* Update gguf.md

* Update gguf.md

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants