Skip to content

[i18n-ar] Translated file : docs/source/ar/fast_tokenizers.md into Arabic#33034

Merged
stevhliu merged 15 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_fast_tokenizers.md
Oct 28, 2024
Merged

[i18n-ar] Translated file : docs/source/ar/fast_tokenizers.md into Arabic#33034
stevhliu merged 15 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_fast_tokenizers.md

Conversation

@AhmedAlmaghz

@AhmedAlmaghz AhmedAlmaghz commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the docs/source/ar/fast_tokenizers.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

This was referenced Sep 27, 2024
Open
Closed
@AhmedAlmaghz AhmedAlmaghz mentioned this pull request Oct 5, 2024
Merged
13 tasks
@AhmedAlmaghz

AhmedAlmaghz commented Oct 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

من هنا نبداء القسم الجديد
@abodacs

DEVELOPER GUIDES

abodacs
abodacs suggested changes Oct 22, 2024
View reviewed changes

@abodacs abodacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

سﻻم عليكم
@AhmedAlmaghz

تمت المراجعة جزاء الله خيرا

Comment thread docs/source/ar/_toctree.yml Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
Comment thread docs/source/ar/fast_tokenizers.md Outdated
AhmedAlmaghz and others added 11 commits October 26, 2024 22:02
@AhmedAlmaghz @abodacs
Update docs/source/ar/_toctree.yml
fb3e970 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
283beef 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
23bd8d4 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
8368ff1 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
da75b0d 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
752cf05 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
3212235 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
267ac7d 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
791c924 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
0ea6f48 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/fast_tokenizers.md
5b10d2e 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz
AhmedAlmaghz marked this pull request as ready for review October 26, 2024 20:54
@AhmedAlmaghz

AhmedAlmaghz commented Oct 26, 2024

Copy link
Copy Markdown
Contributor Author

Thank you @abodacs

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Oct 28, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes Oct 28, 2024
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation and thanks @abodacs for the review! 👏

@stevhliu
stevhliu merged commit a17f287 into huggingface:main Oct 28, 2024
@AhmedAlmaghz
AhmedAlmaghz deleted the Add_docs_source_ar_fast_tokenizers.md branch October 30, 2024 03:22
This was referenced Nov 5, 2024
Merged
Merged
@AhmedAlmaghz AhmedAlmaghz mentioned this pull request Dec 3, 2024
Merged
5 tasks
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
@AhmedAlmaghz @abodacs @BernardZach
[i18n-ar] Translated file : docs/source/ar/fast_tokenizers.md into …
d85ac41 
…Arabic (huggingface#33034)

* Add docs/source/ar/fast_tokenizers.md to Add_docs_source_ar_fast_tokenizers.md

* Update _toctree.yml

* Update _toctree.yml

* Update docs/source/ar/_toctree.yml

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/fast_tokenizers.md

Co-authored-by: Abdullah Mohammed <[email protected]>

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes
+1 more reviewer
@abodacs abodacs abodacs requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AhmedAlmaghz @HuggingFaceDocBuilderDev @abodacs @stevhliu