Skip to content

[i18n-ar] Translated file : docs/source/ar/benchmarks.md into Arabic#33023

Merged
stevhliu merged 15 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_benchmarks.md
Nov 26, 2024
Merged

[i18n-ar] Translated file : docs/source/ar/benchmarks.md into Arabic#33023
stevhliu merged 15 commits into
huggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_benchmarks.md

Conversation

@AhmedAlmaghz

@AhmedAlmaghz AhmedAlmaghz commented Aug 22, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Translated the docs/source/ar/benchmarks.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

This was referenced Sep 27, 2024
Open
Closed
This was referenced Oct 5, 2024
Merged
Merged
This was referenced Nov 5, 2024
Merged
Merged
abodacs
abodacs suggested changes Nov 12, 2024
View reviewed changes

@abodacs abodacs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

السﻻم عليكم

@AhmedAlmaghz
تمت المراجعة جزاء الله خيرا

Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
AhmedAlmaghz and others added 11 commits November 17, 2024 23:55
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
8c5910f 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
d65c9bf 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
8845b29 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
39f6f2b 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
bcd7fb8 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
33d868f 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
0d04130 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
4e42452 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
ac19487 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
b29b666 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz @abodacs
Update docs/source/ar/benchmarks.md
738de71 
Co-authored-by: Abdullah Mohammed <[email protected]>
@AhmedAlmaghz

AhmedAlmaghz commented Nov 17, 2024

Copy link
Copy Markdown
Contributor Author

Thank you @abodacs

@AhmedAlmaghz
AhmedAlmaghz marked this pull request as ready for review November 17, 2024 21:13
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 18, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu reviewed Nov 18, 2024
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread docs/source/ar/benchmarks.md Outdated
Comment thread docs/source/ar/benchmarks.md Outdated
@AhmedAlmaghz

AhmedAlmaghz commented Nov 24, 2024

Copy link
Copy Markdown
Contributor Author

Thank you @stevhliu

stevhliu
stevhliu approved these changes Nov 26, 2024
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stevhliu
stevhliu merged commit 64b73e6 into huggingface:main Nov 26, 2024
@AhmedAlmaghz
AhmedAlmaghz deleted the Add_docs_source_ar_benchmarks.md branch November 29, 2024 04:18
@AhmedAlmaghz AhmedAlmaghz mentioned this pull request Dec 3, 2024
Merged
5 tasks
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
@AhmedAlmaghz @abodacs @BernardZach
[i18n-ar] Translated file : docs/source/ar/benchmarks.md into Arabic (
a67d51f 
huggingface#33023)

* Add docs/source/ar/benchmarks.md to Add_docs_source_ar_benchmarks.md

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update docs/source/ar/benchmarks.md

Co-authored-by: Abdullah Mohammed <[email protected]>

* Update _toctree.yml

* Update benchmarks.md

---------

Co-authored-by: Abdullah Mohammed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes
+1 more reviewer
@abodacs abodacs abodacs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AhmedAlmaghz @HuggingFaceDocBuilderDev @abodacs @stevhliu