Fix mistral ONNX export#31696
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
keras CI looks broken |
ArthurZucker
approved these changes
Jun 28, 2024
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
LGTM as long as compile is still supported?
zhenglongjiepheonix
left a comment
zhenglongjiepheonix
left a comment
Contributor
There was a problem hiding this comment.
looks good to me , it seems still compile-compatible
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ONNX torchscript export fails after #30642 as
exclude_mask |= ...gets mapped toaten::__ior_which is not exportable.aten::bitwise_oris.Using
torch.bitwise_or(exclude_mask, second_mask, out=exclude_mask)breaks as well the ONNX export so using the inplace version of the operator instead.