Skip to content

Enable multi-device for more models#30379

Merged
amyeroberts merged 5 commits into
huggingface:mainfrom
jla524:more_multidevice
Apr 22, 2024
Merged

Enable multi-device for more models#30379
amyeroberts merged 5 commits into
huggingface:mainfrom
jla524:more_multidevice

Conversation

@jla524

@jla524 jla524 commented Apr 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #29786 (issue)

$ pytest tests/models/beit/test_modeling_beit.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 125 items / 118 deselected / 7 selected                                                                                          

tests/models/beit/test_modeling_beit.py ......s                                                                                      [100%]

<warnings redacted>
======================================== 6 passed, 1 skipped, 118 deselected, 3 warnings in 10.95s =========================================

$ pytest tests/models/blip/test_modeling_blip_text.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 80 items / 73 deselected / 7 selected                                                                                            

tests/models/blip/test_modeling_blip_text.py .......                                                                                 [100%]

<warnings redacted>
=============================================== 7 passed, 73 deselected, 1 warning in 2.61s ================================================

$ pytest tests/models/vitmatte/test_modeling_vitmatte.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 109 items / 102 deselected / 7 selected                                                                                          

tests/models/vitmatte/test_modeling_vitmatte.py .......                                                                              [100%]

<warnings redacted>
============================================== 7 passed, 102 deselected, 2 warnings in 5.10s ===============================================

$ pytest tests/models/vitmatte/test_modeling_vitmatte.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 109 items / 102 deselected / 7 selected                                                                                          

tests/models/vitmatte/test_modeling_vitmatte.py .......                                                                              [100%]

<warnings redacted>
============================================== 7 passed, 102 deselected, 2 warnings in 5.21s ===============================================

$ pytest tests/models/vivit/test_modeling_vivit.py -k "offload or parallel"
=========================================================== test session starts ============================================================
platform linux -- Python 3.10.13, pytest-7.4.4, pluggy-1.4.0
rootdir: /root/transformers
configfile: pyproject.toml
plugins: hypothesis-6.98.10, xdist-3.5.0, timeout-2.3.1, anyio-4.3.0
collected 110 items / 103 deselected / 7 selected                                                                                          

tests/models/vivit/test_modeling_vivit.py .......                                                                                    [100%]

<warnings redacted>
============================================== 7 passed, 103 deselected, 2 warnings in 5.42s ===============================================

Who can review?

@amyeroberts

amyeroberts
amyeroberts approved these changes Apr 22, 2024
View reviewed changes

@amyeroberts amyeroberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great piece of work - thanks again for adding this feature to the models! ❤️

@amyeroberts
amyeroberts merged commit 8b02bb6 into huggingface:main Apr 22, 2024
@amyeroberts amyeroberts mentioned this pull request Apr 22, 2024
Closed
59 tasks
@jla524
jla524 deleted the more_multidevice branch April 22, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@amyeroberts amyeroberts amyeroberts approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Community contribution: enabling device_map="auto" support for more vision and multimodal models

2 participants

@jla524 @amyeroberts