Skip to content

[i18n-<zh>] Translating trainer.md to chinese#29728

Closed
chenin-wang wants to merge 3 commits into
huggingface:mainfrom
chenin-wang:main
Closed

[i18n-<zh>] Translating trainer.md to chinese#29728
chenin-wang wants to merge 3 commits into
huggingface:mainfrom
chenin-wang:main

Conversation

@chenin-wang

@chenin-wang chenin-wang commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Part of #26803

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu and @MKhalusova

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

I can only review the technical structure and format of the docs because I can't read Chinese. Do you know of any other contributors who would be interested in reviewing your work? Also pinging @jiaqiw09 and @statelesshz (if you have any free time to review this 🙏 ) who have translated Chinese docs in the past.

Comment thread docs/source/zh/trainer.md
trainer.train()
```

### checkpoints

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be translated?

Suggested change
### checkpoints
### checkpoints

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, translating checkpoints into Chinese is not as easy to understand as checkpoints.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like the tokenizer

Comment thread docs/source/zh/trainer.md Outdated
Comment thread docs/source/zh/trainer.md
@chenin-wang chenin-wang changed the title [i18n-<zh>] Translating trainer.md to chinese #29727 [i18n-<zh>] Translating trainer.md to chinese Mar 20, 2024
@chenin-wang
chenin-wang requested a review from stevhliu March 21, 2024 03:18
@stevhliu

Copy link
Copy Markdown
Member

Hey @chenin-wang! Happy to merge once someone who can read Chinese has reviewed your translation! Do you know anyone who might be interested? The forums and Discord are also a good place to look for other collaborators :)

@github-actions

Copy link
Copy Markdown
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions Bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants