Skip to content

Save (circleci) cache at the end of a job#29141

Merged
ydshieh merged 1 commit into
mainfrom
put_cache_saving_after
Feb 20, 2024
Merged

Save (circleci) cache at the end of a job#29141
ydshieh merged 1 commit into
mainfrom
put_cache_saving_after

Conversation

@ydshieh

@ydshieh ydshieh commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

What does this PR do?

This way, pytest will run before cache saving and we have access to the results earlier in the case of partial or no cache loaded.

@ydshieh
ydshieh requested review from ArthurZucker and amyeroberts and removed request for ArthurZucker February 20, 2024 12:10
Comment thread .circleci/create_circleci_config.py Outdated

@ydshieh ydshieh Feb 20, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see them earlier on the console. The final results will be shown on a tab only when the whole job is finished.

@amyeroberts amyeroberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
ydshieh force-pushed the put_cache_saving_after branch from 4238e46 to 7e5d5fe Compare February 20, 2024 13:02
@ydshieh
ydshieh merged commit 7688d8d into main Feb 20, 2024
@ydshieh
ydshieh deleted the put_cache_saving_after branch February 20, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants