FEAT [Trainer / bnb]: Add RMSProp from bitsandbytes to HF Trainer#29082
Merged
younesbelkada merged 5 commits intoFeb 20, 2024
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Feb 19, 2024
amyeroberts
left a comment
amyeroberts
left a comment
Contributor
There was a problem hiding this comment.
Looks great - thanks for adding!
Co-authored-by: amyeroberts <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As requested by the community, this PR adds the support for bnb RMSProp optimizers to HF Trainer !
RMSPropexists in bitsandbytes since its first commit: bitsandbytes-foundation/bitsandbytes@7439924#diff-8384af03566f84c3055f3fee7b1516696a1546d130d63935714af17781d6202b so this PR is compatible with all versions of bnb.I also added nice tests, which all pass on my machine
Fixes: huggingface/trl#1336
cc @amyeroberts and @Titus-von-Koeller FYI !