Don't use a subset in test fetcher if on main branch#28816
Merged
Conversation
Collaborator
Author
|
Let me know if you want me to explore the option to block a PR being merged if the last commit message is not of the form
|
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Merged
Collaborator
Author
|
@ArthurZucker I think this PR is good to preventing the surprising failures on CircleCI. |
ArthurZucker
approved these changes
Mar 7, 2024
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Alright, trusting you on this one 🤗
amyeroberts
approved these changes
Mar 11, 2024
amyeroberts
left a comment
amyeroberts
left a comment
Contributor
There was a problem hiding this comment.
Thanks for flagging - LGTM, thanks for working on this @ydshieh!
ydshieh
force-pushed
the
prevent_surprise
branch
from
March 11, 2024 15:36
3eeee54 to
6d2ba88
Compare
This was referenced Mar 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[I don't like surprise, like you do I guess] 😉
Don't select a subset from the detected tests to run when they are many - if we are on the main branch.
This could detect any issue as early as at the merge time, not at the nightly run.