Skip to content

[gradient_checkpointing] default to use it for torch 2.3#28538

Merged
ArthurZucker merged 4 commits into
mainfrom
use-rentrant
Feb 20, 2024
Merged

[gradient_checkpointing] default to use it for torch 2.3#28538
ArthurZucker merged 4 commits into
mainfrom
use-rentrant

Conversation

@ArthurZucker

@ArthurZucker ArthurZucker commented Jan 16, 2024

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes #28536 in preparation for next torch release

@ArthurZucker ArthurZucker changed the title default to use it [gradient_checkpointing] default to use it for torch 2.3 Jan 16, 2024
younesbelkada
younesbelkada approved these changes Jan 17, 2024
View reviewed changes

@younesbelkada younesbelkada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@hiyouga

hiyouga commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Why do we use reentrant gc by default? It said the non-reentrant gc can be more advantageous than the reentrant version: https://pytorch.org/docs/2.0/checkpoint.html#torch.utils.checkpoint.checkpoint

@younesbelkada

younesbelkada commented Jan 21, 2024

Copy link
Copy Markdown
Contributor

@hiyouga the use_reentrant=True is used by default in PT anyway so if you set it to None, use_reentrant will be set to True

@github-actions

github-actions Bot commented Feb 17, 2024

Copy link
Copy Markdown
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@ArthurZucker
ArthurZucker marked this pull request as ready for review February 19, 2024 03:40
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Feb 19, 2024

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker
ArthurZucker merged commit 9094abe into main Feb 20, 2024
@ArthurZucker
ArthurZucker deleted the use-rentrant branch February 20, 2024 01:23
@amyeroberts amyeroberts mentioned this pull request Mar 13, 2024
Closed
@lucasjinreal

lucasjinreal commented Apr 9, 2024

Copy link
Copy Markdown

I upgrade transformers to latest, still got this warning, and this warning is logged every single step

s/env-3.9.2/lib/python3.9/site-packages/torch/utils/checkpoint.py:460: UserWarning: torch.utils.checkpoint: please pass in use_reentrant=True or use_reentrant=False explicitly. The default value of use_reentrant will be updated to be False in the future. To maintain current behavior, pass use_reentrant=True. It is recommended that you use use_reentrant=False. Refer to docs for more details on the differences between the two variants.
  warnings.warn(
/data/miniconda3/envs/env-3.9.2/lib/python3.9/site-packages/torch/utils/checkpoint.py:90: UserWarning: None of the inputs have requires_grad=True. Gradients will be None
  warnings.warn(
/data/miniconda3/envs/env-3.9.2/lib/python3.9/site-packages/torch/utils/checkpoint.py:460: UserWarning: torch.utils.checkpoint: please pass in use_reentrant=True or use_reentrant=False explicitly. The default value of use_reentrant will be updated to be False in the future. To maintain current behavior, pass use_reentrant=True. It is recommended that you use use_reentrant=False. Refer to docs for more details on the differences between the two variants.
  warnings.warn(
/data/miniconda3/envs/env-3.9.2/lib/python3.9/site-packages/torch/utils/checkpoint.py:90: UserWarning: None of the inputs have requires_grad=True. Gradients will be None
  warnings.warn(
/data/miniconda3/envs/env-3.9.2/lib/python3.9/site-packages/torch/utils/checkpoint.py:460: UserWarning: torch.utils.checkpoint: please pass in use_reentrant=True or use_reentrant=False explicitly. The default value of use_reentrant will be updated to be False in the future. To maintain current behavior, pass use_reentrant=True. It is recommended that you use use_reentrant=False. Refer to docs for more details on the differences between the two variants.
  warnings.warn(
/data/miniconda3/envs/env-3.9.2/lib/python3.9/site-packages/torch/utils/checkpoint.py:90: UserWarning: None of the inputs have requires_grad=True. Gradients will be None
  warnings.warn(

how to disable it?

@ArthurZucker

ArthurZucker commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator Author

Can you open a new issue with a proper reproducer ?

@LZHgrla LZHgrla mentioned this pull request May 7, 2024
Closed
@qgallouedec qgallouedec mentioned this pull request Jan 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@younesbelkada younesbelkada younesbelkada approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gradient checkpointing throws use_reentrant warning on PyTorch 2.1

5 participants

@ArthurZucker @hiyouga @younesbelkada @HuggingFaceDocBuilderDev @lucasjinreal