Skip to content

[docstring] Fix docstring for ChineseCLIPImageProcessor, ChineseCLIPTextConfig, ChineseCLIPVisionConfig#26880

Merged
ydshieh merged 3 commits into
huggingface:mainfrom
Sparty:ChineseCLIP
Oct 19, 2023
Merged

[docstring] Fix docstring for ChineseCLIPImageProcessor, ChineseCLIPTextConfig, ChineseCLIPVisionConfig#26880
ydshieh merged 3 commits into
huggingface:mainfrom
Sparty:ChineseCLIP

Conversation

@Sparty

@Sparty Sparty commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #26638

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

vignesh-raghunathan added 2 commits October 17, 2023 15:18
@Sparty
Sparty force-pushed the ChineseCLIP branch 2 times, most recently from 17ebdea to daeff08 Compare October 17, 2023 19:35
@Sparty
Sparty marked this pull request as ready for review October 17, 2023 20:20
…p.py, image_processing_chinese_clip.py with type and docstring values
@Sparty

Sparty commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

@ydshieh Could you please review this?

@ydshieh ydshieh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sparty ! Very nice work 💯 !

@ydshieh
ydshieh merged commit 816c223 into huggingface:main Oct 19, 2023
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* Remove ChineseCLIPImageProcessor, ChineseCLIPTextConfig, ChineseCLIPVisionConfig from check_docstrings

* Run fix_and_overwrite for ChineseCLIPImageProcessor, ChineseCLIPTextConfig, ChineseCLIPVisionConfig

* Replace <fill_type> and <fill_docstring> in configuration_chinese_clip.py, image_processing_chinese_clip.py with type and docstring values

---------

Co-authored-by: vignesh-raghunathan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Community Event] Docstring Sprint

3 participants