Skip to content

Update README_hd.md#26872

Merged
stevhliu merged 2 commits into
huggingface:mainfrom
biswabaibhab007:patch-1
Oct 20, 2023
Merged

Update README_hd.md#26872
stevhliu merged 2 commits into
huggingface:mainfrom
biswabaibhab007:patch-1

Conversation

@biswabaibhab007

Copy link
Copy Markdown
Contributor
  • Fixed broken links.

I hope this small contribution adds value to this project.

- Fixed broken links
I hope this small contribution adds value to this project.
@ArthurZucker
ArthurZucker requested a review from stevhliu October 18, 2023 09:15

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the links!

One more minor change and then we can merge :)

Comment thread README_hd.md Outdated
Co-authored-by: Steven Liu <[email protected]>
@biswabaibhab007

Copy link
Copy Markdown
Contributor Author

I've committed the suggestion you can merge it now.

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

Comment thread README_hd.md
@biswabaibhab007

Copy link
Copy Markdown
Contributor Author

@stevhliu btw on line 90 there's jax installation if that's what you meant you .

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to keep the translation as close to the English one as possible. There's a mention of Jax installation on line 259 🙂

I added a link to the Jax doc for you if you don't mind, let me know if that translates correctly!

Comment thread README_hd.md

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the fix!

@stevhliu
stevhliu merged commit 224794b into huggingface:main Oct 20, 2023
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* Update README_hd.md

- Fixed broken links
I hope this small contribution adds value to this project.

* Update README_hd.md

Co-authored-by: Steven Liu <[email protected]>

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants