Bring back the PR Refactor doctests + add CI to main#23271
Conversation
sgugger
left a comment
There was a problem hiding this comment.
Can you put the new testing utils (from doctest_utils) in testing_utils, so it all goes in the same place?
In this case, am I allowed to put the import of try:
import pytest # We don't need a hard dependency on pytest in the main library
except ImportError:
return test_case |
|
There is no direct import into |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
| - v0.6-repository_consistency | ||
| - run: pip install --upgrade pip | ||
| - run: pip install .[all,quality] | ||
| - run: pip install pytest |
There was a problem hiding this comment.
This shouldn't be necessary now, no?
Refactor doctests + add CI to main
|
Thanks for taking care of this! Think the filtered list could be obtain in a cleaner way with some bash commands but otherwise great 👍🏻 |
|
@ArthurZucker It was finally going to a The bash command was just getting too complex ... |
|
Nice! Thanks for following up |
…#23271) * Revert "Revert "[Doctests] Refactor doctests + add CI" (huggingface#23245)" This reverts commit 69ee462. * try not expose HfDocTestParser * move into testing_utils.py * remove pytest install --------- Co-authored-by: ydshieh <[email protected]>
…#23271) * Revert "Revert "[Doctests] Refactor doctests + add CI" (huggingface#23245)" This reverts commit 69ee462. * try not expose HfDocTestParser * move into testing_utils.py * remove pytest install --------- Co-authored-by: ydshieh <[email protected]>
Reverts #23245
So we can keep the PR #22987 regarding the new doctest way, but without exposing
doctest_utilstosrc/transformers.@sgugger Let me know if you prefer to move this
doctest_utils.pytotestsfolder.