Revert "[Doctests] Refactor doctests + add CI"#23245
Merged
Merged
Conversation
This reverts commit 627f447.
ydshieh
approved these changes
May 9, 2023
ydshieh
left a comment
ydshieh
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for rescue the 🔥 .
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
ydshieh
added a commit
that referenced
this pull request
May 10, 2023
* Revert "Revert "[Doctests] Refactor doctests + add CI" (#23245)" This reverts commit 69ee462. * try not expose HfDocTestParser * move into testing_utils.py * remove pytest install --------- Co-authored-by: ydshieh <[email protected]>
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
Revert "[Doctests] Refactor doctests + add CI (huggingface#22987)" This reverts commit 627f447.
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…#23271) * Revert "Revert "[Doctests] Refactor doctests + add CI" (huggingface#23245)" This reverts commit 69ee462. * try not expose HfDocTestParser * move into testing_utils.py * remove pytest install --------- Co-authored-by: ydshieh <[email protected]>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
Revert "[Doctests] Refactor doctests + add CI (huggingface#22987)" This reverts commit 627f447.
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…#23271) * Revert "Revert "[Doctests] Refactor doctests + add CI" (huggingface#23245)" This reverts commit 69ee462. * try not expose HfDocTestParser * move into testing_utils.py * remove pytest install --------- Co-authored-by: ydshieh <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #22987
This PR created a hard dependency on
pytestwhich we don't want in Transformers. Looking a bit more it would be better if the wholedoctest_utils.pymodule lived outside of the Transformers library, so it should be structured differently.