[Generate] Greedy Search, fix output scores from logits to scores#17442
Merged
patrickvonplaten merged 1 commit intoMay 31, 2022
Merged
Conversation
patrickvonplaten
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 31, 2022
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Good for me, so that the output is consistently scores.
patil-suraj
approved these changes
May 31, 2022
patil-suraj
left a comment
patil-suraj
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
🚨🚨 This PR can lead to silently changing values for users of greedy_search and output_scores=True. Please read the issue below 🚨 🚨
went through the issue, and it's fine for me since this will actually return the correct scores.
Narsil
pushed a commit
to Narsil/transformers
that referenced
this pull request
Jun 7, 2022
elusenji
pushed a commit
to elusenji/transformers
that referenced
this pull request
Jun 12, 2022
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jun 16, 2022
|
@patil-suraj Will there be any support for raw logits instead logits that are processed? (see #17521 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🚨🚨 This PR can lead to silently changing values for users of
greedy_searchandoutput_scores=True. Please read the issue below 🚨 🚨Fixes #17424
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.