Revert "Handle PyTorch to Flax conversion of 1D convolutions" #15540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 854a0d5.
|
The documentation is not available anymore as the PR was closed or merged. |
patil-suraj
approved these changes
Feb 7, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
You are right that we don't actually need this. Thanks a lot for spotting this!
stevhliu
pushed a commit
to stevhliu/transformers
that referenced
this pull request
Feb 18, 2022
…face#15519)" (huggingface#15540) This reverts commit 854a0d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15519
@patil-suraj @sanchit-gandhi - please see comment on PR. Let me know if I'm mistaken there and we actually do need this new weight conversion, but I really don't see why this would be the case.