Skip to content

Error when group_by_length is used with an IterableDataset#15437

Merged
LysandreJik merged 1 commit into
masterfrom
group_by_lebngth_check
Jan 31, 2022
Merged

Error when group_by_length is used with an IterableDataset#15437
LysandreJik merged 1 commit into
masterfrom
group_by_lebngth_check

Conversation

@sgugger

@sgugger sgugger commented Jan 31, 2022

Copy link
Copy Markdown
Collaborator

What does this PR do?

Since group_by_length is not supported for IterableDatasets, we should raise an error at the trainer init when we detect that arg is set and the training set is an IterableDataset.

Fixes #15418

@sgugger
sgugger requested a review from LysandreJik January 31, 2022 16:57
@HuggingFaceDocBuilder

HuggingFaceDocBuilder commented Jan 31, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@LysandreJik LysandreJik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM!

@LysandreJik
LysandreJik merged commit 0c17e76 into master Jan 31, 2022
@LysandreJik
LysandreJik deleted the group_by_lebngth_check branch January 31, 2022 20:33
gante pushed a commit to gante/transformers that referenced this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notify user if group_by_length won't be used

3 participants