Add Camembert to models exportable with ONNX#14059
Merged
michaelbenayoun merged 11 commits intoOct 26, 2021
Merged
Conversation
fix `OnnxConfig` import
sgugger
approved these changes
Oct 20, 2021
sgugger
left a comment
sgugger
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for your PR! It looks very clean.
Could you make sure to run make style on your branch to get rid of the quality error?
sgugger
reviewed
Oct 25, 2021
| @@ -0,0 +1,8 @@ | |||
| timestamp,experiment_id,project_name,duration,emissions,energy_consumed,country_name,country_iso_code,region,on_cloud,cloud_provider,cloud_region | |||
Collaborator
There was a problem hiding this comment.
I think this file was added by mistake.
sgugger
reviewed
Oct 25, 2021
| @@ -0,0 +1,3 @@ | |||
| timestamp,experiment_id,project_name,duration,emissions,energy_consumed,country_name,country_iso_code,region,on_cloud,cloud_provider,cloud_region | |||
Contributor
Author
There was a problem hiding this comment.
I don't know where does these files comes from. It's probably because I tried to run make test before make style but it wasn't really needed or successfull :)
Contributor
Author
|
I don't understand why |
michaelbenayoun
left a comment
michaelbenayoun
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution!
add suggestion Co-authored-by: Michael Benayoun <[email protected]>
michaelbenayoun
approved these changes
Oct 26, 2021
michaelbenayoun
left a comment
michaelbenayoun
left a comment
Member
There was a problem hiding this comment.
Everything looks great, thank!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I added lines to make Camembert models available for Onnx conversion.
Issue
This is linked to this conversation #13952
@LysandreJik