remove unwanted control-flow code from DeBERTa-V2 #13145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalkraj
changed the title
| r_pos = relative_pos | ||
|
|
||
| p2c_pos = torch.clamp(-r_pos + att_span, 0, att_span * 2 - 1) | ||
| if query_layer.size(-2) != key_layer.size(-2): |
Contributor
There was a problem hiding this comment.
All
``` self.query_proj = nn.Linear(config.hidden_size, self.all_head_size, bias=True)
self.key_proj = nn.Linear(config.hidden_size, self.all_head_size, bias=True)
self.value_proj = nn.Linear(config.hidden_size, self.all_head_size, bias=True)```
have the same dim which is why this control flow is never true no?
LGTM to remove for me
Contributor
Author
There was a problem hiding this comment.
have the same dim which is why this control flow is never true no?
Yes
Contributor
Author
There was a problem hiding this comment.
Deberta-v2 same dim always. so the control flow is never true
patrickvonplaten
approved these changes
Aug 18, 2021
LysandreJik
approved these changes
Aug 23, 2021
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM, thanks @kamalkraj
cc @BigBird01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes never executed branch from
deberta-v2codediscussed in #13120 (comment)
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@LysandreJik @patrickvonplaten @Rocketknight1