Feature request
Change the implementation of SiglipProcessor to use the global default behavior for padding of False or update the documentation to indicate the usage is different and defaults to 'max_length' if the padding argument is not provided.
Motivation
In the HF documentation for padding (both the docs as well as the function comments for the processor class), the default behavior (argument) is described to be False or 'do_not_pad'. For the SiglipProcessor, max_length is the default behavior implemented in code while the example in the docs omits the padding argument. This is at odds with the overall documentation as well as behavior / usage examples provided in similar models such as CLIP (where explicitly padding=True in the usage example) and could give the wrong impression upon first glance that padding is not used for SigLIP.
Your contribution
Opening this issue to discuss a clarification / improvement. I can help implement the preferred solution.
Feature request
Change the implementation of
SiglipProcessorto use the global default behavior forpaddingofFalseor update the documentation to indicate the usage is different and defaults to'max_length'if thepaddingargument is not provided.Motivation
In the HF documentation for padding (both the docs as well as the function comments for the processor class), the default behavior (argument) is described to be
Falseor'do_not_pad'. For theSiglipProcessor,max_lengthis the default behavior implemented in code while the example in the docs omits the padding argument. This is at odds with the overall documentation as well as behavior / usage examples provided in similar models such as CLIP (where explicitlypadding=Truein the usage example) and could give the wrong impression upon first glance that padding is not used for SigLIP.Your contribution
Opening this issue to discuss a clarification / improvement. I can help implement the preferred solution.