Merged
Conversation
1 task
Contributor
Author
|
Ok we are almost ready to merge this! The last missing piece is the Node typings. I'm not sure what's the best way to handle this @Pierrci |
|
This is a great addition. Any info on an ETA for the merge into master? |
This was referenced May 22, 2020
Pierrci
reviewed
May 22, 2020
| @@ -1,6 +1,11 @@ | |||
| const native = require("./native"); | |||
|
|
|||
| class Tokenizer extends native.tokenizer_Tokenizer { | |||
Member
There was a problem hiding this comment.
@n1t0 I went for something very simple, I was not completely sure at first that it would work but it does 😁.
Let me know if it's good for you, I might add more JS tests early next week, but feel free to merge without them!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15