Repository navigation
Implement import allowlist in AutoPeftModel, limit access in megatron - #3090
Merged
githubnemo merged 4 commits intoApr 16, 2026
Merged
Conversation
added 3 commits
March 11, 2026 12:30
Partially resolves huggingface#3085. AutoPeftModel resolves the base model's class by importing the parent library mentioned in the adapter config which makes way for potentially executing malicious code on the adapter creator's behalf. While this is not a remote code execution vulnerability by itself (since the attacker still needs to install a malicious package on the system) it can be used for code execution in case the attacker has file system access, for example.
I haven't found any evidence that one wants to load other modules than `megatron.*`, so we limit it to that.
Collaborator
Author
|
cc @spartan8806 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for the quick turnaround. |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. |
BenjaminBossan
approved these changes
Apr 16, 2026
BenjaminBossan
left a comment
BenjaminBossan
left a comment
Member
There was a problem hiding this comment.
We can give it a try and roll back if it causes trouble.
| target_base_layer = target | ||
|
|
||
| if config.megatron_config: | ||
| if not config.megatron_core.startswith("megatron."): |
Member
There was a problem hiding this comment.
I don't remember the specifics anymore and after checking the PR from back then couldn't find anything, but I vaguely remember that there were explicit cases where another lib might be needed. How about solving this similarly to below with a patch-able allow list?
BenjaminBossan
approved these changes
Apr 16, 2026
BenjaminBossan
left a comment
BenjaminBossan
left a comment
Member
There was a problem hiding this comment.
Thanks for the update, LGTM.
8 tasks
2 of 5 tasks
abdulfatir
added a commit
to amazon-science/chronos-forecasting
that referenced
this pull request
Aug 14, 2026
## Fix `peft` 0.20 ([huggingface/peft#3090](huggingface/peft#3090)) enforces an import allowlist when resolving a LoRA adapter's `auto_mapping.parent_library`. For Chronos-2 adapters this is `chronos.chronos2.model`, which is not in the default allowlist, so `Chronos2Pipeline.from_pretrained` on an adapter raises: ``` ValueError: The auto mapping wants to import 'chronos.chronos2.model' which is not in the import allowlist. ``` This broke `test_chronos2_lora_pipeline_loads_from_disk` in CI once `peft` 0.20 was pulled in. We now pass `import_allowlist=["chronos"]` (peft matches on the module prefix, so this covers any submodule under our own package) when loading an adapter. The call is guarded on `peft>=0.20.0` since the kwarg does not exist in older versions within our supported range (`peft>=0.18.1`); the guard can be dropped once the minimum is 0.20. ## Testing `test/test_chronos2.py::test_chronos2_lora_pipeline_loads_from_disk` passes with `peft` 0.20.0 installed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Abdul Fatir Ansari <[email protected]> Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3085.
AutoPeftModelresolves the base model's class by importing the parent library mentioned in the adapter config which makes way for potentially executing malicious code on the adapter creator's behalf. While this is not a remote code execution vulnerability by itself (since the attacker still needs to install a malicious package on the system) it can be used for code execution in case the attacker has file system access, for example.The same is happening for the
megatron.coreconfig key. I haven't found any evidence thatmegatronwants to load other modules thanmegatron.*, so we limit it to that.There was a bit of missing documentation, typo, missing
hub_online_once, so I took the opportunity to fix that along the way.