FEAT: add awq suppot in PEFT#1399
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks a lot for adding this Younes. I have a few comments, could you please check?
|
|
||
| def is_auto_awq_available(): | ||
| if importlib.util.find_spec("awq") is not None: | ||
| # TODO: change it to 0.2.0 |
There was a problem hiding this comment.
This is not quite clear to me: change it when?
There was a problem hiding this comment.
Sorry I'll remove it
|
|
||
| def is_auto_awq_available(): | ||
| if importlib.util.find_spec("awq") is not None: | ||
| # TODO: to change it to 0.2.0 after the AutoAWQ release |
There was a problem hiding this comment.
@BenjaminBossan I 'll change that to 0.2.0 before merging right after auto-awq's release
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for fixing the remaining issues, LGTM now. Let's run another test after the release to ensure that PEFT works with the release version and then this should be good to be merged.
|
AutoAWQ just made the release (thanks @casper-hansen !) - Reran the docker build and tests on my T4 machine and seems to work all well ! Merging once the CI is green ! |
* add awq suppot in PEFT * fix * fux * Update src/peft/tuners/lora/awq.py * style & fix tests * forward contrib credits from PR14084 * forward contrib credits from autoawq PR * change name * fix * change to peft internal testing * fix * fix * add multi-GPU tests * add to dockerfile * fix todo * raise error only at the dispatch level * quality * fix test * fix dockerfile * fix * fix * update dockerfile and tests --------- Co-authored-by: s4rduk4r <[email protected]>
* add awq suppot in PEFT * fix * fux * Update src/peft/tuners/lora/awq.py * style & fix tests * forward contrib credits from PR14084 * forward contrib credits from autoawq PR * change name * fix * change to peft internal testing * fix * fix * add multi-GPU tests * add to dockerfile * fix todo * raise error only at the dispatch level * quality * fix test * fix dockerfile * fix * fix * update dockerfile and tests --------- Co-authored-by: s4rduk4r <[email protected]>
4 participants
Original PR: casper-hansen/AutoAWQ#220
TODO:
Add the fix in transformers
Wait for the next awq release
Empty commit with @s4rduk4r as a co-author
add autoawq in the docker image
Figure out how to fix the current bug on the test
cc @pacman100 @casper-hansen