Skip to content

[BT] add BetterTransformer support for ProphetNet#923

Merged
fxmarty merged 6 commits into
huggingface:mainfrom
hirotasoshu:feature/prophetnet-bettertransformer-layer
Mar 29, 2023
Merged

[BT] add BetterTransformer support for ProphetNet#923
fxmarty merged 6 commits into
huggingface:mainfrom
hirotasoshu:feature/prophetnet-bettertransformer-layer

Conversation

@hirotasoshu

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #488 and huggingface/transformers#20372

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@hirotasoshu

hirotasoshu commented Mar 26, 2023

Copy link
Copy Markdown
Contributor Author

With hf-internal-testing/tiny-random-prophetnet and hf-internal-testing/tiny-random-ProphetNetModel models in tests i got this error:
image
That's why i used microsoft/prophetnet-large-uncased.
Let me know if i need to replace it with some tiny model with bigger max_position_embeddings

@hirotasoshu hirotasoshu changed the title [BT] add BetterTransformer support for ProphetNet [BT] add BetterTransformer support for ProphetNet Mar 26, 2023
@hirotasoshu

hirotasoshu commented Mar 27, 2023

Copy link
Copy Markdown
Contributor Author

I figured out how to change tiny-random-prophetnet model to make the tests work and upload it to huggingface. Now in the tests it is used

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Mar 28, 2023

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@fxmarty fxmarty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for the addition!

@fxmarty
fxmarty merged commit 2766116 into huggingface:main Mar 29, 2023
@hirotasoshu
hirotasoshu deleted the feature/prophetnet-bettertransformer-layer branch March 29, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Community contribution - BetterTransformer integration for more models!

3 participants