Skip to content

Refactor of 2 functions used in ORTModel#551

Merged
michaelbenayoun merged 3 commits into
huggingface:mainfrom
michaelbenayoun:infer_filename_refactor
Dec 7, 2022
Merged

Refactor of 2 functions used in ORTModel#551
michaelbenayoun merged 3 commits into
huggingface:mainfrom
michaelbenayoun:infer_filename_refactor

Conversation

@michaelbenayoun

Copy link
Copy Markdown
Member

What does this PR do?

  • Refactors validate_file_exists
  • Refactors infer_filename
  • Fixes function name in optimum/exporters/onnx/__main__.py (cc @mht-sharma)

As mentioned in #515 (cc @fxmarty)

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Dec 6, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

Comment thread optimum/utils/file_utils.py Outdated
Revision is the specific model version to use. It can be a branch name, a tag name, or a commit id.

Returns:
`List[Path`]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`List[Path`]
`List[Path]`

@fxmarty fxmarty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@michaelbenayoun
michaelbenayoun merged commit f6eb417 into huggingface:main Dec 7, 2022
@michaelbenayoun
michaelbenayoun deleted the infer_filename_refactor branch December 7, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants