Update readme#550
Merged
Merged
Conversation
echarlaix
requested review from
JingyaHuang,
fxmarty,
michaelbenayoun and
regisss
December 6, 2022 11:31
|
The documentation is not available anymore as the PR was closed or merged. |
JingyaHuang
approved these changes
Dec 6, 2022
JingyaHuang
left a comment
JingyaHuang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating and refectoring the README, it looks great!
fxmarty
reviewed
Dec 6, 2022
fxmarty
reviewed
Dec 6, 2022
Co-authored-by: fxmarty <[email protected]>
regisss
reviewed
Dec 7, 2022
regisss
left a comment
regisss
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this PR @echarlaix!
I left a few comments. Although this PR has been merged, we can discuss them here to see if some changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we modify the README to present the inference example before the training example (as it could interest more people) and adds some examples links. Will update the documentation after the changes have been validated