Add CLIP BetterTransformer#534
Merged
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
fxmarty
marked this pull request as ready for review
December 6, 2022 14:24
younesbelkada
approved these changes
Dec 6, 2022
younesbelkada
left a comment
younesbelkada
left a comment
Contributor
There was a problem hiding this comment.
Thanks very much for working on this and adding CLIP support for BetterTransformer
I left a single comment, otherwise everything looks great
As you have touched one of the core transform function I would prefer to run the slow tests on GPU before merging. Let me run them tomorrow if that works for you.
Co-authored-by: Younes Belkada <[email protected]>
Contributor
Author
|
Tests pass locally on GPU, so I'll merge. I don't think there is any workflow for GPU tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support is only for the vision model, as the text model uses causal attention that is likely not supported by PyTorch Better Transformer.