Skip to content

Fix CLIPSdpaAttention had dropped since v4.48#2245

Merged
echarlaix merged 1 commit into
huggingface:mainfrom
mybigday:main
May 9, 2025
Merged

Fix CLIPSdpaAttention had dropped since v4.48#2245
echarlaix merged 1 commit into
huggingface:mainfrom
mybigday:main

Conversation

@hans00

@hans00 hans00 commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes huggingface/optimum-onnx#67

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil

Copy link
Copy Markdown
Member

@hans00 thanks, please also increment the opset version of clip to 14 to enable export of sdpa.

@eaidova

eaidova commented May 9, 2025

Copy link
Copy Markdown
Contributor

@echarlaix

Copy link
Copy Markdown
Collaborator

@hans00 thanks, please also increment the opset version of clip to 14 to enable export of sdpa.

just added in #2256 so we can merge this one

@echarlaix

Copy link
Copy Markdown
Collaborator

Thanks for the fix @hans00

@echarlaix
echarlaix merged commit cf8eca0 into huggingface:main May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot convert Gemma-3-4B QAT to ONNX

5 participants