add dinov2 onnx optimizer support#2227
Merged
IlyasMoutawwakil merged 2 commits intoApr 24, 2025
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
hi, can you please rebase your branch, I will retrigger the tests afterwards. |
Contributor
Author
Done, thanks! |
Contributor
Author
|
Looks to me like the two failing checks fail with the same errors in the latest commit to main |
Member
|
Thanks @EFord36 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following the addition of Dinov2 Onnx export support in #2001 , this PR seeks to enable optimiser support for DinoV2.
I thought I'd have a go at this since I could see ViT was supported, and DinoV2 is just a ViT backbone.
I think this is working - when I run the test locally, it actually fails, but the output is visually identical, and the test for vit fails for me in the same way. I suspect this is something about my environment - opening the PR to see how it behaves on CI, I can debug further when I get a chance.
Fixes # (issue)
Before submitting
Who can review?
Onnx runtime related, so:
@fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun