avoid library_name guessing if it is known in parameters standartization#2179
Merged
echarlaix merged 2 commits intoFeb 12, 2025
Merged
Conversation
Contributor
Author
|
@echarlaix @IlyasMoutawwakil could you please take a look? |
3 tasks
IlyasMoutawwakil
approved these changes
Feb 4, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@IlyasMoutawwakil @echarlaix could you please merge? Failed tests are not related (it looks like temporal connection to server issues) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
in case if library_name detection has additional logic on optimum-integration path and not defined inside standard task manager approach to find library (e.g. open_clip integration), parameters standardization may fail as the library will not be detected properly.
Before submitting
Who can review?