Skip to content

[RT-Detr] - Add RT-Detr Onnx Config#2040

Closed
YHallouard wants to merge 7 commits into
huggingface:mainfrom
YHallouard:feat/add_config_for_RT_DETR_onnx
Closed

[RT-Detr] - Add RT-Detr Onnx Config#2040
YHallouard wants to merge 7 commits into
huggingface:mainfrom
YHallouard:feat/add_config_for_RT_DETR_onnx

Conversation

@YHallouard

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@YHallouard

Copy link
Copy Markdown
Contributor Author

Hi @fxmarty, @echarlaix, @JingyaHuang, @michaelbenayoun,

I'm creating this PR following @qubvel and @ArthurZucker advices on that PR: huggingface/transformers#33877

@echarlaix echarlaix left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the addition @YHallouard

Comment thread optimum/exporters/onnx/model_configs.py
Comment thread optimum/exporters/tasks.py
@YHallouard

Copy link
Copy Markdown
Contributor Author

Hi @echarlaix, thanks for the review!

I added "PekingU/rtdetr_r18vd" for testing, but I saw that you used hf-internal-testing. Should I create a random initiated model their ?

@YHallouard

Copy link
Copy Markdown
Contributor Author

Hi @echarlaix, what are your insights ? I made the changes but should I create a random initiated model in hf-internal-testing ?

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix

echarlaix commented Dec 17, 2024

Copy link
Copy Markdown
Collaborator

Apologies for the delay @YHallouard, just fixed the conflicts so that we can soon merge. Two things must be fixed before we can merge :

def inputs(self) -> Dict[str, Dict[int, str]]:
return {
"pixel_values": {0: "batch_size", 1: "num_channels", 2: "height", 3: "width"},
"pixel_mask": {0: "batch_size"},

@echarlaix echarlaix Dec 18, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it needed ? (not needed for ViT models but might be needed for RT-DETR)

@echarlaix echarlaix Dec 18, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also if needed shouldn't the height / width dimension set to dynamic as well?

@ggolda

ggolda commented Jan 16, 2025

Copy link
Copy Markdown

Looks like this task got stuck, do you need any help on it? Would be really great to have RT-DETR exporter for onnx.

@echarlaix

Copy link
Copy Markdown
Collaborator

Closed with #2201

@echarlaix echarlaix closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants