Merged
Conversation
hanouticelina
changed the title
hf skills to bucket and rename upgrade -> update
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
force-pushed
the
cli-skills-bucket-marketplace
branch
3 times, most recently
from
5d92d01 to
fd79e50
Compare
Switch `hf skills add` / `hf skills upgrade` to read marketplace metadata and skill files from the `huggingface/skills` bucket via `HfApi.list_bucket_tree` and `HfApi.download_bucket_files`. Avoids GitHub API rate limits when agents are also making GH calls. The bucket is populated by a workflow on `huggingface/skills` that uploads skills + `marketplace.json` on every merge to `main`. `hf skills upgrade` now always re-syncs from the bucket (no per-skill revision tracking).
Filter the local skill dir list by selector *before* loading the marketplace and re-syncing, so a typo no longer downloads every managed skill before erroring out. Also include an actionable hint in the error message.
hanouticelina
force-pushed
the
cli-skills-bucket-marketplace
branch
from
fd79e50 to
c1900fe
Compare
hanouticelina
changed the title
hf skills to bucket and rename upgrade -> updatehf skills to bucket
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 85034b4. Configure here.
`download_bucket_files` requires `hf_xet` so the live tests fail in CI envs
without the optional dep. Mark the class with `@requires("hf_xet")`.
`list_bucket_tree(prefix=...)` matches as a raw string prefix, so asking for `skills/gradio` can also return `skills/gradio-tools/...`. Existing `_buckets.py:_list_remote_files` has the same defense.
…ketplace # Conflicts: # tests/test_cli.py
Wauplin
approved these changes
May 4, 2026
Contributor
|
This PR has been shipped as part of the v1.14.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
hf skills add/hf skills updateto fetch the skills from the huggingface/skills bucket instead of the GitHub API. the bucket is populated by a workflow onhuggingface/skillsthat syncs skills +marketplace.jsonon every merge tomain(companion PR: huggingface/skills#134).Note
Medium Risk
Switches the
hf skillsinstall/update backend from GitHub tarball/commit polling to Hugging Face bucket listing/downloading, changing update semantics and managed-skill detection. Risk is mainly around regressions in install/update behavior (file filtering, partial downloads, and compatibility with older installs).Overview
hf skills add/hf skills updatenow fetch marketplace metadata and skill contents from thehuggingface/skillsbucket (vialist_bucket_tree+download_bucket_files) instead of the GitHub API/tarballs.Update behavior is simplified to a re-sync: managed installs are detected via a marker file (
.hf-skill-manifest.json, now an empty touch file kept for backward compatibility) and are reinstalled atomically; revision-basedupdate_available/updatedstatuses and manifest parsing/writing are removed. Production CLI tests are updated accordingly and gated behindhf_xet.Reviewed by Cursor Bugbot for commit 73f215a. Bugbot is set up for automated code reviews on this repo. Configure here.