Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Wauplin
changed the title
|
(merging because I believe this is the type of low-quality PR to review - worth case it breaks on next release and we fix it) |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b0f9ea3. Configure here.
| VERSION="${{ needs.prepare.outputs.version }}" | ||
| BASE_VERSION=$(echo "$VERSION" | sed -E 's/\.rc.*//') | ||
| BUCKET_URL="https://huggingface.co/buckets/huggingface/releases/tree/huggingface_hub/${BASE_VERSION}/socials" | ||
| BUCKET_URL="https://huggingface.co/buckets/huggingface/releases/tree/huggingface_hub/${BASE_VERSION}" |
There was a problem hiding this comment.
Bucket path uses VERSION but Slack URL uses BASE_VERSION
Low Severity
The "Upload to bucket" step syncs to a path using ${VERSION} directly (line 734), but the "Notify Slack" step constructs BUCKET_URL using ${BASE_VERSION} (derived via sed -E 's/\.rc.*//'). These two variables refer to different derivations of the same value. For minor-release they happen to be equal since the prepare step already strips the RC suffix, but using different variable names for the same path is misleading and fragile if the job condition ever changes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b0f9ea3. Configure here.
|
This PR has been shipped as part of the v1.14.0 release. |
1 participant
Summary
minor-releaseinstead ofminor-prerelease, giving time to manually review/edit the GitHub release notes between the RC and the final release.hf://buckets/huggingface/releases/huggingface_hub/<version>/release_notes.txtalongside the social posts.🤖 Generated with Claude Code
Note
Medium Risk
Changes the release workflow gating and artifact publishing paths; misconfiguration could cause missing social drafts or bucket uploads during a production release.
Overview
Moves the
social-postsjob to run onminor-release(instead of prerelease) so social drafts are generated from the final, manually edited GitHub release notes.Updates release-note fetching to prefer the exact final tag (post-promotion) with a minor-version fallback, and changes bucket publishing to sync a single staged directory containing both social drafts and an archived
release_notes.txtunderhf://.../huggingface_hub/${VERSION}/(with Slack linking to the new base bucket path).Reviewed by Cursor Bugbot for commit b0f9ea3. Bugbot is set up for automated code reviews on this repo. Configure here.