[Release] Mark minor releases as "latest" on GitHub#4167
Conversation
Co-authored-by: Lucain <[email protected]>
Wauplin
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9da63d1. Configure here.
| --tag "$TAG" \ | ||
| --prerelease=false | ||
| --prerelease=false \ | ||
| --latest |
There was a problem hiding this comment.
--latest on draft release causes API validation error
High Severity
The gh release edit command adds --latest but does not include --draft=false. The release being edited was created as --draft --prerelease (in the minor-prerelease step). Setting --prerelease=false alone leaves it as a draft. The GitHub API rejects make_latest: true on draft releases with a validation error ("Latest release cannot be draft or prerelease"), so this command will fail — preventing the tag update, prerelease flag change, and the entire "Promote draft release to final version" step from succeeding.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 9da63d1. Configure here.
|
This PR has been shipped as part of the v1.13.0 release. |
2 participants
Summary
When publishing a GitHub release, minor releases should be labelled as "latest release" — patch releases should not take over that label, so that the latest minor version stays highlighted on the repo's releases page.
Changes in
.github/workflows/release.yml:gh release edit): added--latestso that promoting the prerelease draft to a final release explicitly marks it as "latest".Slack Thread