[Internal] Fix slack-message draft release permissions + update model#4119
Merged
[Internal] Fix slack-message draft release permissions + update model#4119
Conversation
The slack-message job failed because it had `contents: read` permissions and couldn't list draft GitHub releases created by the release-notes job. Upgrade to `contents: write` so `gh release list` can see drafts. Also update RELEASE_NOTES_MODEL to zai-org/GLM-5.1.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
I opened #4119 as a follow-up to make the |
Contributor
|
This PR has been shipped as part of the v1.12.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slack-message job failed because it had
contents: readpermissions and couldn't list draft GH releases created by therelease-notesjob. Upgrade tocontents: writesogh release listcan see drafts.i was looking for separate releases permission scope but
contents: writeis the minimum to access draft release notes, cf: cli/cli#3037Also update
RELEASE_NOTES_MODELtozai-org/GLM-5.1.Note
Medium Risk
Workflow now grants the
slack-messagejob broadercontents: writepermissions, increasing the blast radius of a compromised job/token; functional changes are otherwise limited to switching the AI model used for generated text.Overview
Fixes the prerelease
slack-messagejob by elevating its GitHub Actions permissions tocontents: write, allowinggh release listto see draft releases created earlier in the workflow.Updates the OpenCode
RELEASE_NOTES_MODELused for both GitHub release-note generation and Slack announcement generation fromhuggingface/MiniMaxAI/MiniMax-M2.5tozai-org/GLM-5.1.Reviewed by Cursor Bugbot for commit 821637d. Configure here.