Ignore .gitattributes when copying repo files to a bucket#4082
Merged
Conversation
`.gitattributes` is git-specific metadata that is not relevant in a bucket context. Skip it automatically in `copy_files` when the source is a repository. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
approved these changes
Apr 10, 2026
Contributor
|
This PR has been shipped as part of the v1.11.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: https://huggingface.slack.com/archives/C0A4RUVRLSC/p1775725585026259 (internal private thread)
.gitattributesfiles are specific to git-based repos. Let's not copy them to buckets.🤖 Generated with Claude Code
Note
Low Risk
Low risk: small behavioral change limited to
copy_fileswhen the source is a repo, with no auth/data model changes. Main risk is unexpected omission if a user intentionally wanted.gitattributescopied to a bucket.Overview
Updates
HfApi.copy_filesto exclude.gitattributeswhen the source is a repository, both for single-file copies (early return) and recursive folder copies (filter during tree walk).Documents this repo-to-bucket filtering in the
copy_filesdocstring; bucket-to-bucket copy behavior is unchanged.Reviewed by Cursor Bugbot for commit ee2f122. Bugbot is set up for automated code reviews on this repo. Configure here.