[CLI] spaces hot-reload: misc improvements#4049
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
hanouticelina
requested changes
Apr 7, 2026
Co-authored-by: célina <[email protected]>
cbensimon
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 47d616a. Configure here.
cbensimon
changed the title
Contributor
|
This PR has been shipped as part of the v1.12.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contents
git pulljust-in-time instruction--local-fileis a PATHNote
Medium Risk
Touches the experimental
hf spaces hot-reloadflow, including commit parent selection and post-upload SHA verification, which could affect reliability of hot-reload and error handling. Changes are localized to CLI/docs and SSE client timeout behavior.Overview
Improves
hf spaces hot-reloadrobustness by pinning uploads to the currently running Space SHA viaparent_commit, then waiting for Space info to reflect the new commit and failing fast if the reported SHA doesn’t match.Enhances CLI UX by treating
--local-fileas aPATH(and documenting it), adding a non-TTY fallback that preserves the downloaded file and prints explicit next-step commands, printing a just-in-timegit pull --autostashhint for local-clone workflows, and always labeling the output with a "Hot-reload summary:" header.Increases the hot-reload SSE HTTP client timeout (via
CLIENT_TIMEOUT) to reduce premature stream failures.Reviewed by Cursor Bugbot for commit 4e1b016. Bugbot is set up for automated code reviews on this repo. Configure here.