[FIX] [CI] Fix upgrading release notes to latest release#4045
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently getting
in CI when trying to upgrade the
1.x.x.rcXrelease notes to1.x.x. Issue is that it's looking for a draft release but between the 2 runs we usually manually moved the release notes from draft to "ready" (but as prerelease instead of release).This PR removes the "isDraft" check
Example: https://github.com/huggingface/huggingface_hub/actions/runs/23940040924/job/69824210746
Note
Medium Risk
Changes release promotion behavior in the GitHub Actions
release.ymlworkflow; incorrect matching could update the wrong release tag for a minor version and affect published release metadata.Overview
Fixes the
minor-releasepromotion step in.github/workflows/release.ymlto stop requiring a draft GitHub release when upgrading RC notes to the final tag.Instead of filtering
gh release listresults byisDraft, the workflow now selects any existing release whosetagNamestarts with the target minor (e.g.v1.9.) and edits that release to retag it as the final version, avoiding fallback creation of a new release with auto-generated notes.Written by Cursor Bugbot for commit 622003d. This will update automatically on new commits. Configure here.