Repository navigation
Conversation
Ayoubhm07
force-pushed
the
fix/hub-symlink-spec-windows
branch
from
October 3, 2026 00:29
3d014d7 to
462dede
Compare
The spec asserted that createSymlink never produces a symlink on win32, but Windows creates them with Developer Mode or admin rights, so two tests failed on those machines even though createSymlink worked. The node:fs/promises mock in this file already wraps symlink, so it now records whether the real call succeeded and the two assertions compare against that instead of guessing from the platform.
Ayoubhm07
force-pushed
the
fix/hub-symlink-spec-windows
branch
from
October 3, 2026 00:34
462dede to
599b862
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createSymlinkfalls back to copying whenfs.symlinkthrows, and the spec encoded that fallback as a platform rule. Windows does create symlinks with Developer Mode on, so on those machinescreateSymlinktakes the symlink path and two assertions fail while nothing is broken. CI never caught it because the runners have no symlink privilege, which is also why the platform check looked right.The
node:fs/promisesmock in this file already wrapssymlink, so it now records whether the real call went through and the assertions follow that. Six lines, no probing, no new helper.Before, on
main(Windows 11, Developer Mode on):After:
One thing this gives up: the old assertion demanded
trueunconditionally on Linux, so it would have failed iffs.symlinkever stopped working there. Keeping that guard would mean putting aprocess.platformbranch back in, and the copy path is already covered by the third test.Test file only. No source change, no dependency.