Escape { in user supplied html#408
Merged
Merged
Conversation
mishig25
force-pushed
the
fix_escaping_inside_html
branch
from
September 25, 2023 21:02
e8c837a to
031eef1
Compare
mishig25
added a commit
to huggingface/transformers
that referenced
this pull request
Sep 25, 2023
mishig25
pushed a commit
to mishig25/transformers.js
that referenced
this pull request
Sep 25, 2023
mishig25
added a commit
to huggingface/course
that referenced
this pull request
Sep 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When there
{is within a user supplied html string, it was causing svelte compiler error since{is a reserved character.Solution
Escape
{with{Description of steps:
<div><p>test</p></div>will be parsed as single node without children. AST playground{with{within textsShould fix https://github.com/xenova/transformers.js/actions/runs/6300637437/job/17103917897?pr=320
todos: