[CI] pin max torch version to fix CI errors#9709
Merged
Merged
Conversation
sayakpaul
reviewed
Oct 18, 2024
Member
a-r-r-o-w
commented
Oct 18, 2024
Contributor
Author
sayakpaul
approved these changes
Oct 19, 2024
sayakpaul
left a comment
sayakpaul
left a comment
Member
There was a problem hiding this comment.
LGTM. IIRC you already triggered the CI, so should be good.
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
* pin max torch version * update * Update setup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Only pinned until we figure out what's going on with torch 2.5.0
Context: https://huggingface.slack.com/archives/C065E480NN9/p1729230272869569
#9691, #9704
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.