#3487 Fix inpainting strength for various samplers #3532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Hey @rupertmenneer, This fix makes a lot of sense to me! Sadly it interferes a bit with the PR here: #3533 that we just merged. Could you maybe rebase your PR? 😅 |
added 3 commits
May 26, 2023 17:12
…ps < 1 when strength adjusts the num_inference_steps then the inpainting pipeline should fail
…e_sigma when pure noise updated this commit w.r.t the latest merge here: huggingface#3533
rupertmenneer
force-pushed
the
inpainting_strength_fixes
branch
from
58c2580 to
c66604b
Compare
Contributor
Author
|
Hey @patrickvonplaten no problem at all - these things happen! Took me 1 minute to fix. 👍 Rebased and accepted your changes on the conflict, and then resubmitted my fix on top! Just waiting for CI to pass but I am sure it will be all sweet. |
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…gface#3532) * Throw error if strength adjusted num_inference_steps < 1 * Added new fast test to check ValueError raised when num_inference_steps < 1 when strength adjusts the num_inference_steps then the inpainting pipeline should fail * fix huggingface#3487 initial latents are now only scaled by init_noise_sigma when pure noise updated this commit w.r.t the latest merge here: huggingface#3533 * fix --------- Co-authored-by: Patrick von Platen <[email protected]>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…gface#3532) * Throw error if strength adjusted num_inference_steps < 1 * Added new fast test to check ValueError raised when num_inference_steps < 1 when strength adjusts the num_inference_steps then the inpainting pipeline should fail * fix huggingface#3487 initial latents are now only scaled by init_noise_sigma when pure noise updated this commit w.r.t the latest merge here: huggingface#3533 * fix --------- Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following additions:
num_inference_steps< 1 due to strength adjustment.num_inference_steps< 1.