attend and excite batch test causing timeouts #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamberman
commented
Feb 26, 2023
Comment on lines
138
to
140
| def test_inference_batch_single_identical(self): | ||
| self._test_inference_batch_single_identical(relax_max_difference=False) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is calling the helper with the default function argument, so don't need to override mixin function
williamberman
force-pushed
the
attend_and_excite_test_batch_timeouts
branch
from
6c25e34 to
dde7095
Compare
|
The documentation is not available anymore as the PR was closed or merged. |
williamberman
requested review from
patil-suraj,
patrickvonplaten,
pcuenca,
sayakpaul and
yiyixuxu
and removed request for
yiyixuxu
sayakpaul
approved these changes
Feb 27, 2023
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Do we have any idea on the upper bound that causes things to timeout?
yiyixuxu
approved these changes
Feb 27, 2023
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
In attend-and-exicte each latent is optimized individually so batching was done in a loop hense the timeout - I would love to know if there is a way to do it more efficiently too!
mengfei25
pushed a commit
to mengfei25/diffusers
that referenced
this pull request
Mar 27, 2023
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.