Fix: Use incorrect temporary variable key when replacing adapter name…#12502
Merged
yiyixuxu merged 3 commits intohuggingface:mainfrom Oct 21, 2025
Merged
Fix: Use incorrect temporary variable key when replacing adapter name…#12502yiyixuxu merged 3 commits intohuggingface:mainfrom
yiyixuxu merged 3 commits intohuggingface:mainfrom
Conversation
… in state dict within load_lora_adapter function
Contributor
Author
|
plz take some time to review it |
BenjaminBossan
approved these changes
Oct 20, 2025
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
Ouch, my bad. Thanks for catching and fixing this.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a variable name typo in the load_lora_adapter function where an incorrect temporary variable key was used instead of k when modifying state dict keys during LoRA adapter hotswapping.
The error occurred in the map_state_dict_for_hotswap helper function, specifically in the condition checking for lora_A.weight and lora_B.weight suffixes. This typo would have caused unexpected behavior when remapping keys for hotswapped adapters, as key was not defined in that scope.
This change ensures consistent use of the loop variable k to correctly modify the state dict keys, maintaining the intended logic for adapter hotswapping.