[ci] xfail more incorrect transformer imports.#12455
Conversation
| assert deprecated_warning_msg in str(cap_logger), "Deprecation warning not found in logs" | ||
|
|
||
| @pytest.mark.xfail(condition=is_transformers_version(">", "4.56.2"), reason="Some import error", strict=True) | ||
| def test_download_safetensors_only_variant_exists_for_model(self): |
There was a problem hiding this comment.
Perhaps I am missing something, but it appears that this test (and test_download_safetensors_variant_does_not_exist_for_model below) are still marked as failed rather than xfailed in the CI:
FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_safetensors_only_variant_exists_for_model
FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_safetensors_variant_does_not_exist_for_model
Is this expected?
There was a problem hiding this comment.
Yeah this is not expected and seeing for the first time. Let me check.
dg845
left a comment
dg845
left a comment
There was a problem hiding this comment.
It looks like the following tests are still failing on the CI:
tests/pipelines/test_pipelines.py::DownloadTests::test_download_bin_only_variant_exists_for_modeltests/pipelines/test_pipelines.py::DownloadTests::test_download_bin_variant_does_not_exist_for_model
These tests also previously failed on the (unrelated) PR #12463, see #12463 (comment). So probably these tests should also be xfail-ed?
|
Hmm, I am not sure why the Transformers version is showing up to 4.57.0-dev here: https://github.com/huggingface/diffusers/actions/runs/18487464650/job/52673652920?pr=12455#step:5:19 whereas it should have been 5.0.0-dev. My plate is a little full at the moment to dive deeper into it. So, I have made the xfail non-strict, which should hopefully unblock us. But I am open to other suggestions. To double-check, I tried to replicate the exact same CI environment:
|
dg845
left a comment
dg845
left a comment
There was a problem hiding this comment.
LGTM! I think test_download_bin_only_variant_exists_for_model should also be marked as xfail for now, as it fails with the CLIPFeatureExtractor/CLIPImageProcessor issue in the CI:
FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_download_bin_only_variant_exists_for_model - AttributeError: module transformers has no attribute CLIPFeatureExtractor
2 participants
What does this PR do?
Hopefully, the last ones.