Skip to content

Translation to Bengali#89

Merged
lewtun merged 10 commits into
huggingface:mainfrom
eNipu:main
Apr 6, 2022
Merged

Translation to Bengali#89
lewtun merged 10 commits into
huggingface:mainfrom
eNipu:main

Conversation

@eNipu

@eNipu eNipu commented Apr 4, 2022

Copy link
Copy Markdown
Contributor
  • This pull request contains the translation of Chapter 0 in Bengali
  • The translation of _toctree.yml file (chapter 0-1)
    The other chapters are WIP.

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution @eNipu ! We just need to tweak the _toctree.yml file, but otherwise this looks good to go!

Comment thread chapters/bn/_toctree.yml Outdated
- local: chapter0/1
title: ভূমিকা

- title: 1. ট্রান্সফরমার মডেল

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating the whole Table of Contents, but we should only include the sections that have a corresponding set of translated MDX files. In this case, we should remove everything from this line downwards

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewtun Thanks for the quick review. Got it 👍🏾
I just changed accordingly. Hope this will fix the issue.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, what I meant is that _toctree.yml should only include this:

- title: 0. সেটআপ
  sections:
  - local: chapter0/1
    title: ভূমিকা

Everything else should be removed until we have the corresponding MDX files translated. Would you mind fixing that? Sorry for the bother!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewtun No worries. Thank you for the quick feedback. Just fixed that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for iterating - this looks great!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for iterating - this looks great!

Comment thread chapters/bn/chapter0/1.mdx Outdated
[FIX] syntax formatting

Co-authored-by: lewtun <[email protected]>
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 5, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun
lewtun merged commit c4a44e4 into huggingface:main Apr 6, 2022
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants