Skip to content

Translation to Russian#88

Merged
lewtun merged 10 commits into
huggingface:mainfrom
pdumin:main
Apr 4, 2022
Merged

Translation to Russian#88
lewtun merged 10 commits into
huggingface:mainfrom
pdumin:main

Conversation

@pdumin

@pdumin pdumin commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

Chapter0/1, chapter1/1-3 finished

Related to #75

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 4, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution 🤗 ! There's just a small change needed on the table of contents, but otherwise this looks good to me (I did a quick translation to English)

Comment thread chapters/ru/_toctree.yml Outdated
title: Обработка естесственного языка
- local: chapter1/3
title: Трансформеры, на что они способны?
# - local: chapter1/4

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on including just the sections that have been translated! To help simplify the Git merges for future PRs, can you please delete these commented out sections?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed what you asked for.

path_to_docs: course/chapters/
additional_args: --not_python_module
languages: en es fr he pt th tr
languages: en es fr he pt ru th tr

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've added Russian to this list so we can test the docs build in the CI :)

Removing comments with untranslated sections
@lewtun

lewtun commented Apr 4, 2022

Copy link
Copy Markdown
Member

The docs build looks good: https://moon-ci-docs.huggingface.co/course/pr_88/ru/chapter1/1

Screen Shot 2022-04-04 at 16 51 17

@lewtun

lewtun commented Apr 4, 2022

Copy link
Copy Markdown
Member

Thank you for iterating on this! Merging now and will deploy to the website today :)

@lewtun
lewtun merged commit f816f90 into huggingface:main Apr 4, 2022
@artyomboyko

Copy link
Copy Markdown
Contributor

Good afternoon. Can you tell me for what reason the translated subtitles of the first part of the course from YouTube were removed?

GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants