Korean chapter0, 1 full#80
Conversation
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thank you for this contribution @Doohae 🚀 ! I'll ask someone in the Korean community for a quick review, but in the meantime you can make some small tweaks to the table of contents - thank you!
rainmaker712
left a comment
rainmaker712
left a comment
There was a problem hiding this comment.
There are few parts need to be changed + double check for url & image links.
bzantium
left a comment
bzantium
left a comment
There was a problem hiding this comment.
Review chapter0
- align all expressions: using "합니다" instead of "요"
- revise english-like expressions (일부 의역)
wavy-jung
changed the title
|
The documentation is not available anymore as the PR was closed or merged. |
lewtun
left a comment
lewtun
left a comment
There was a problem hiding this comment.
Thanks for integrating the PR feedback @Doohae ! I noticed one of the URLs is pointing to the wrong place, but otherwise this looks good 🤗
Once we've fixed the URL, I think we can merge this!
| @@ -0,0 +1,121 @@ | |||
| # 강의 소개 | |||
|
|
|||
| Hugging Face 강의에 오신 여러분들 환영합니다! 이번 강의 소개에서는 작업 환경 설정에 대해 안내드리겠습니다. 방금 막 이번 과정을 시작하셨다면 먼저 [Chapter 1](notion://www.notion.so/course/chapter1) 내용을 살펴보고 돌아오신 뒤, 환경을 설정하여 코드를 직접 실행해보시길 추천드립니다. | |||
There was a problem hiding this comment.
Does this Notion link exist? I think the following should work:
| Hugging Face 강의에 오신 여러분들 환영합니다! 이번 강의 소개에서는 작업 환경 설정에 대해 안내드리겠습니다. 방금 막 이번 과정을 시작하셨다면 먼저 [Chapter 1](notion://www.notion.so/course/chapter1) 내용을 살펴보고 돌아오신 뒤, 환경을 설정하여 코드를 직접 실행해보시길 추천드립니다. | |
| Hugging Face 강의에 오신 여러분들 환영합니다! 이번 강의 소개에서는 작업 환경 설정에 대해 안내드리겠습니다. 방금 막 이번 과정을 시작하셨다면 먼저 [Chapter 1](/course/ko/chapter1) 내용을 살펴보고 돌아오신 뒤, 환경을 설정하여 코드를 직접 실행해보시길 추천드립니다. |
| choices={[ | ||
| { | ||
| text: "요약", | ||
| explain: "이 페이지를 다시 확인하세요 <a href=\"[https://huggingface.co/roberta-large-mnli\\](https://huggingface.co/roberta-large-mnli%5C%5C)">roberta-large-mnli page</a>." |
There was a problem hiding this comment.
| explain: "이 페이지를 다시 확인하세요 <a href=\"[https://huggingface.co/roberta-large-mnli\\](https://huggingface.co/roberta-large-mnli%5C%5C)">roberta-large-mnli page</a>." | |
| explain: "이 페이지를 다시 확인하세요 <a href=\"https://huggingface.co/roberta-large-mnli\">roberta-large-mnli page</a>." |
| }, | ||
| { | ||
| text: "텍스트 생성", | ||
| explain: "이 페이지를 다시 확인하세요 <a href=\"[https://huggingface.co/roberta-large-mnli\\](https://huggingface.co/roberta-large-mnli%5C%5C)">roberta-large-mnli page</a>." |
There was a problem hiding this comment.
We need to change this here to build the docs properly :)
| explain: "이 페이지를 다시 확인하세요 <a href=\"[https://huggingface.co/roberta-large-mnli\\](https://huggingface.co/roberta-large-mnli%5C%5C)">roberta-large-mnli page</a>." | |
| explain: "이 페이지를 다시 확인하세요 <a href=\"https://huggingface.co/roberta-large-mnli\">roberta-large-mnli page</a>." |
| path_to_docs: course/chapters/ | ||
| additional_args: --not_python_module | ||
| languages: en es fr he pt th tr | ||
| languages: en es fr he ko pt th tr |
There was a problem hiding this comment.
FYI I've added Korean to the list here so we can build the docs on the website once this PR is merged :)
|
Hey @Doohae we have some merge conflicts in the GitHub CI files due to some recent changes from other translations. Would you mind resolving them so we can try building the docs on this PR? Thanks! |
Hello, I'm the assignee of Korean translation(chapter 1)
I just created _toctree.yml file and finished translation for ko/chapter1/1.mdx
Please check out for the translation and the form!
Planned to gotta finish all other part of chapter1 in a day 😄
Related to issue #42