Skip to content

[th] Translated chapter3/introduction#73

Merged
lewtun merged 5 commits into
huggingface:mainfrom
a-krirk:main
Apr 5, 2022
Merged

[th] Translated chapter3/introduction#73
lewtun merged 5 commits into
huggingface:mainfrom
a-krirk:main

Conversation

@a-krirk

@a-krirk a-krirk commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Hi,
I've translated chapter3 titles and chapter3/introduction to Thai. #64

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice contribution @a-krirk ❤️ ! I'll ask the Thai community for a quick review, but otherwise the only thing to fix up is the table of contents file

Comment thread chapters/th/_toctree.yml Outdated
@@ -0,0 +1,173 @@
- title: 0. Setup

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need to keep the entries for the translated chapters. In this case, please remove everything except the parts for chapter 3

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! sorry for mistakes here. Fixed accordingly.

Comment thread chapters/th/_toctree.yml Outdated
sections:
- local: chapter3/1
title: บทนำ
- local: chapter3/2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't yet have the translated files for chapter3/2 etc, we should also remove these entries here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Fixed accordingly

@lewtun lewtun mentioned this pull request Mar 31, 2022
69 tasks
Comment thread chapters/th/_toctree.yml
Comment thread chapters/th/_toctree.yml

# บทนำ

ใน [Chapter 2](/course/chapter2) เราได้เรียนรู้วิธีการใช้ tokenizers และโมเดลที่ผ่านการเทรนมาแล้ว (pretrained models) ในการทำนาย แต่ถ้าเราต้องการจะใช้ dataset ของเราเองในการ fine-tune โมเดลล่ะ? นั่นคือหัวข้อของบทนี้เลย! คุณจะได้เรียนรู้:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity, are you keeping "pretrained models" in English because there isn't a good equivalent in Thai? One alternative I've seen in other languages is to translate the technical terms and then put the English equivalent afterwards in parentheses, e.g.

TRANSLATED_TERMS (ENGLISH_TERMS เป็นภาษาอังกฤษ)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, lewtun

I've translated the word 'pretrained models' to 'โมเดลที่ผ่านการเทรนมาแล้ว' , so the format is just like the example you gave above.
And to answer your question, Yes, I think 'โมเดลที่ผ่านการเทรนมาแล้ว' is not exact equivalent to 'pretrained models' as the word 'pretrained' have some underlying meanings which I can't translate all of them in one word.

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you for iterating on this! LGTM 🚀

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 5, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun

lewtun commented Apr 5, 2022

Copy link
Copy Markdown
Member

Docs built well, so merging this 🚀

Screen Shot 2022-04-05 at 14 26 20

@lewtun
lewtun merged commit 7d20de9 into huggingface:main Apr 5, 2022
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
[th] Translated chapter3/introduction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants