Skip to content

french setup#57

Merged
lewtun merged 4 commits into
huggingface:mainfrom
abdouaziz:main
Apr 1, 2022
Merged

french setup#57
lewtun merged 4 commits into
huggingface:mainfrom
abdouaziz:main

Conversation

@abdouaziz

@abdouaziz abdouaziz commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

what does this PR do ?

This PR adds the French Setup for the chapter 0

@lewtun

lewtun commented Mar 30, 2022

Copy link
Copy Markdown
Member

Thank you for this contribution @abdouaziz!

Would you mind adding the the table of contents file (_toctree.yml) for this section? You can take a look at how I did this for Spanish here: https://github.com/huggingface/course/blob/main/chapters/es/_toctree.yml

Just make sure this file is stored under chapters/fr/ and it should be good to go!

@abdouaziz

abdouaziz commented Mar 30, 2022

Copy link
Copy Markdown
Contributor Author

Thank you for this contribution @abdouaziz!

Would you mind adding the the table of contents file (_toctree.yml) for this section? You can take a look at how I did this for Spanish here: https://github.com/huggingface/course/blob/main/chapters/es/_toctree.yml

Just make sure this file is stored under chapters/fr/ and it should be good to go!

Hi @lewtun now you can check if it's good

@lewtun lewtun mentioned this pull request Mar 31, 2022
Open
69 tasks
lewtun
lewtun approved these changes Apr 1, 2022
View reviewed changes

@lewtun lewtun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR 🤗

lewtun
lewtun reviewed Apr 1, 2022
View reviewed changes
Comment thread .github/workflows/build_documentation.yml
path_to_docs: course/chapters/
additional_args: --not_python_module
languages: en es th tr
languages: en es fr th tr

@lewtun lewtun Apr 1, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I added French to the CI so we can build the French content on the website

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 1, 2022 •
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lewtun
lewtun merged commit ce63e93 into huggingface:main Apr 1, 2022
GITbaburin pushed a commit to GITbaburin/course that referenced this pull request May 17, 2026
@lewtun
Merge pull request huggingface#57 from abdouaziz/main
5c3aa8a 
french setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lewtun lewtun lewtun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abdouaziz @lewtun @HuggingFaceDocBuilderDev